Skip to content

Highlighting of heading "Automatic Registration of Presenters" + add …#1060

Closed
mildabre wants to merge 150 commits into
nette:masterfrom
mildabre:patch-17
Closed

Highlighting of heading "Automatic Registration of Presenters" + add …#1060
mildabre wants to merge 150 commits into
nette:masterfrom
mildabre:patch-17

Conversation

@mildabre

@mildabre mildabre commented Nov 2, 2024

Copy link
Copy Markdown
Contributor

…info

Highlight the heading "Automatic Registration of Presenters" so that it is permanently placed in the side menu and is permanently visible in the menu - this theme is important!

Add more information about scanDirs: false consequences on decorating presenters

@dg dg force-pushed the master branch 29 times, most recently from e0bc7f4 to 3c92c82 Compare December 18, 2024 14:49
@dg

dg commented Jul 5, 2026

Copy link
Copy Markdown
Member

Thanks — two parts here, and I took one of them.

Taken: the scanDirs: false consequences. I verified it in ApplicationExtension: with scanDirs: false, findPresenters() doesn't run, so presenters aren't auto-registered as services — which means the decorator section can't touch them and their creation falls back to a slower path. Documented in both languages, with a link to the decorator section.

Not taken: promoting the heading to top level. scanDirs lives under application:, so "Automatic Registration of Presenters" is genuinely a subsection of the "Application" config block — pulling it up to H1 would make it look like a separate config section rather than part of application:. So I kept it as H2. (I also left the intro sentence as-is to keep the churn minimal.)

Closing since the branch can't be merged directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.